Skip to content

Conversation

@siaeyy
Copy link

@siaeyy siaeyy commented Sep 16, 2025

  • UTF-8 decoder and MUTF-8 encoder are written
  • They are implemented in chat message packet handler

Time for criticism
Closes #52

Decode utf-8 content from char array to uint32_t array
Encode raw content from uint32_t array to uint8_t array within given length
Cap messages without breaking utf-8 format
…port

Before sending a message to clients, decode utf-8 formatted value and encode it ot mutf-8.

With format change, now unicode characters are supported.
Copy link
Owner

@p2r3 p2r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very light review, I'll adjust the style nitpicks myself once these points are addressed. Otherwise, smells like good code.

Also, I'm sorry to inform you that I'll probably be merging #112 first. Prepare for conflicts!

@p2r3
Copy link
Owner

p2r3 commented Sep 18, 2025

Yep, there go the merge conflicts. Good luck 😅

@siaeyy
Copy link
Author

siaeyy commented Sep 18, 2025

Conflicts chose me as the victim :c

@siaeyy siaeyy force-pushed the unicode-support branch 2 times, most recently from 0f1b679 to 78f0117 Compare September 24, 2025 15:23
@siaeyy siaeyy requested a review from p2r3 September 24, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unicode chat messages aren't supported

2 participants