-
Notifications
You must be signed in to change notification settings - Fork 196
Unicode Support #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unicode Support #111
Conversation
Decode utf-8 content from char array to uint32_t array
Encode raw content from uint32_t array to uint8_t array within given length
Cap messages without breaking utf-8 format
…port Before sending a message to clients, decode utf-8 formatted value and encode it ot mutf-8. With format change, now unicode characters are supported.
p2r3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very light review, I'll adjust the style nitpicks myself once these points are addressed. Otherwise, smells like good code.
Also, I'm sorry to inform you that I'll probably be merging #112 first. Prepare for conflicts!
|
Yep, there go the merge conflicts. Good luck 😅 |
|
Conflicts chose me as the victim :c |
0f1b679 to
78f0117
Compare
Time for criticism
Closes #52