Include parentheticals in format names by default#607
Open
omega-fallon wants to merge 1 commit intop2r3:masterfrom
Open
Include parentheticals in format names by default#607omega-fallon wants to merge 1 commit intop2r3:masterfrom
omega-fallon wants to merge 1 commit intop2r3:masterfrom
Conversation
In main.ts, code removes parenthetical portions of a format's name, with the stated reason being to remove "handler-specific information". Having a look through the formats currently supported, I can't see any for which this is actually the case. Format names seem to always use parentheticals as clarification, for example, to specify an acronym, or a specific sub-format. A few of these—for example, the N64 rom formats—are useful information a user might want to know, and removing it leaves 3 formats with identical names, only differentiated by their extension. If there are indeed cases where the parenthetical is handler-specific, I think there's a better way of handling this than just removing all parentheticals outright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In main.ts, code removes parenthetical portions of a format's name, with the stated reason being to remove "handler-specific information". Having a look through the formats currently supported, I can't see any for which this is actually the case. Format names seem to always use parentheticals as clarification, for example, to specify an acronym, or a specific sub-format. A few of these—for example, the N64 rom formats—are useful information a user might want to know, and removing it leaves 3 formats with identical names, only differentiated by their extension.
If there are indeed cases where the parenthetical is handler-specific, I think there's a better way of handling this than just removing all parentheticals outright.