fix: resolve infinite loop in path search algorithm#610
Open
Waleed-Ahmad-dev wants to merge 1 commit intop2r3:masterfrom
Open
fix: resolve infinite loop in path search algorithm#610Waleed-Ahmad-dev wants to merge 1 commit intop2r3:masterfrom
Waleed-Ahmad-dev wants to merge 1 commit intop2r3:masterfrom
Conversation
* Replace visited array with minCosts map to prune redundant paths * Remove flawed visitedBorder property from QueueNode * Improve performance by skipping nodes with higher or equal costs * Prevent exponential path explosion during complex conversions like PPTX to PDF Fixes # 605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug where the graph traversal algorithm gets caught in an infinite loop during complex format conversions (like
pptxtopdfvia pandoc).Fixes #605
Why is it needed?
Because
pandocregisters a massive number of input/output combinations (creating over 4,000 edges), the pathfinding algorithm was experiencing an exponential path explosion. The customvisitedBorderlogic was failing to properly prune redundant paths, causing the browser/app to hang indefinitely.How was it fixed?
visitedarray andvisitedBorderlogic with aminCostsMap.visitedBorderproperty from theQueueNodeinterface.How was it tested?
pptxtopdf.