Correct a bug with parsing PacketIn controller metadata #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug manifests itself if bit_offset becomes 8 or larger, which happens in some cases if there are multiple fields in the packet-in header that are not a multiple of 8 bits wide. Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
antoninbas
approved these changes
May 16, 2025
Member
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
LGTM, even though I'd suggest adding a corresponding test case in https://github.com/p4lang/PI/blob/main/proto/tests/test_proto_fe_packet_io.cpp
…h it Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Contributor
Author
I made a small change to one of the existing unit tests, and verified that without the proposed fix the test fails, but with the proposed fix the test passes. |
Contributor
Author
|
Merging this, after modifying an existing test case so that it would have caught the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug manifests itself if bit_offset becomes 8 or larger, which happens in some cases if there are multiple fields in the packet-in header that are not a multiple of 8 bits wide.