Update comment for weights_disallowed in ActionProfile #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Lam <matthew.lam.qwerty@gmail.com>
matthewtlam
force-pushed
the
matthewtlam
branch
from
bb2198e to
cc911aa
Compare
smolkaj
approved these changes
Oct 16, 2025
Member
smolkaj
left a comment
smolkaj
left a comment
There was a problem hiding this comment.
Thanks for the follow-up fixes!
Member
|
@chrispsommers would you be able to take a quick look and merge if this looks good -- provided you agree that we don't need to wait until the next P4 API WG meeting in this case. |
chrispsommers
approved these changes
Oct 16, 2025
Collaborator
RACE CONDITION! I was approving it while this e-mail was in transit. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @jonathan-dilorenzo and @smolkaj