Skip to content

Conversation

@glaubinix
Copy link
Member

@glaubinix glaubinix commented Nov 7, 2025

Pagination isn't part yet of the public API of the client, so wouldn't document this here just yet

Testing Instructions

  • Might be easiest to set the LIMIT to 1
  • Fetch all items of a resource where you have more than one
  • Assert that multiple requests have been made
  • Assert that the return value is still the same

@glaubinix glaubinix self-assigned this Nov 7, 2025
@glaubinix glaubinix marked this pull request as draft November 7, 2025 12:07
@pscheit pscheit self-assigned this Nov 11, 2025
@stevenrombauts stevenrombauts marked this pull request as ready for review November 25, 2025 13:57
@stevenrombauts stevenrombauts marked this pull request as draft November 26, 2025 13:22
@stevenrombauts
Copy link
Contributor

Changing this after our discussion regarding the max_restarts option in PluginChain: without changing that configuration, this plugin will cause an exception to be thrown after the 10th page. Probably better to just handle this directly in our own code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now so much more readable! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants