Fix formatting issue in Slack notifications#753
Merged
Conversation
Krusty93
requested review from
LazyAfternoons and
grausof
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Slack notification formatting in the TLS certificate renewal GitHub Actions workflow by replacing shell-style variable references (which aren’t evaluated in with: inputs) with GitHub Actions expression syntax.
Changes:
- Inline
steps.calc_cert_name.outputs.kv_cert_namein the first Slack failure message and remove the now-unneededCERT_NAMEenv mapping. - Replace
$KV_CERT_NAMEwith${{ env.KV_CERT_NAME }}in the second Slack failure message to ensure the certificate name is rendered correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silvicir
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not a bash script, so github syntax must be used (
${{ env... }})