Conversation
BenitoVisone
suggested changes
Jul 17, 2024
Contributor
BenitoVisone
left a comment
There was a problem hiding this comment.
I suppose that in the auth_flow diagram we're missing two interactions between steps 6 and 7:
update SAMLSessionrecord with theSAMLResponseparameter after the redirect POST on thesaml/acsendpointinit OIDCSessionrecord after successful issuing of theauthorization_code
chore: maybe it could be useful to add the /token POST request after the step 7. to make init of AccessTokenSession Record more explicit
Signed-off-by: himazawa <73994521+himazawa@users.noreply.github.com>
Contributor
BenitoVisone
left a comment
There was a problem hiding this comment.
- In the
auth_flowI would connect the/tokento theAPI Gatewayinstead of directly tooneid-ecs-core - In the
metadata_flowI would add the Parameter Store dependency because the lambda will need it to sign and public the metadata with the certificate
sebbalex
reviewed
Dec 6, 2024
Contributor
|
@himazawa @BenitoVisone I think we're all set here, can we merge it? |
BenitoVisone
previously approved these changes
Jan 8, 2025
Co-authored-by: Alessandro Sebastiani <sebbalex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.