remove DSS key references; upgrade paramiko dependency to version 4.0#307
remove DSS key references; upgrade paramiko dependency to version 4.0#307rawwar wants to merge 9 commits intopahaz:masterfrom
Conversation
53fea17 to
dc269b8
Compare
|
Looks like, its not possible to enable rolling build from appveyor.yml config. it needs to be done via UI - https://www.appveyor.com/docs/build-configuration/#rolling-builds Appveyor builds are running for every commit. I think, we don't need the older builds running when the PR is updated . |
d856e37 to
2d5a41d
Compare
2d5a41d to
b93a5e9
Compare
|
@pahaz , I did make a lot of changes in the PR assuming too many things. Appreciate your feedback and how we want to resolve this. |
|
Also, for Appveyor config, do you know what will be the python path? I did some debugging and still was unable to figure it out. I did try adding more debug logs. |
|
any updates ? @pahaz |
|
Maybe release 0.4.1 where bamp paramico <=3.5.1 |
|
Thanks for your tremendous work — really appreciate it! 🙌 I’d like to keep basic compatibility with older Paramiko and Python 2 for now. The library is used in closed environments where upgrades are slow, so a softer transition would help. I agree with #309 it will be the best for now. My proposal:
Happy to help with testing this path. I’ll revisit this PR a bit later. |
Is it reasonable to consider both in parallel? |
Raising this PR as Apache Airflow uses this package. We wanted to bump paramiko>=4.0.0(PR). But, found that
sshtunneluses DSS Key. I did see earlier PR's. But, they were failing tests. This is my attempt to try to fix them.Note: I've used copilot