Skip to content

fix ci configuration#312

Open
bmos wants to merge 15 commits intopahaz:masterfrom
bmos:patch-2
Open

fix ci configuration#312
bmos wants to merge 15 commits intopahaz:masterfrom
bmos:patch-2

Conversation

@bmos
Copy link
Copy Markdown

@bmos bmos commented Feb 26, 2026

Goals

  • Update CircleCI configuration for better maintainability and more complete testing of supported python versions.
  • Only change program and test code by adjusting formatting or adding noqa comments to get the checks passing.

What is this change?

  • Refactor CI workflow and tooling configurations so that all supported versions of python are tested successfully.
  • Remove .egg files from the pypi upload process as they're no longer accepted.
  • Move documentation generation to a discrete workflow as it's not code validation.

Considerations for discussion

  • Tests are only run if syntax validation passes. Would it be preferable to run testing regardless?
  • Python 3.4 testing has been removed as it's not supported by CircleCI. Is this important to have?
  • Checksum of tests/requirements-syntax.txt has been added to the CI cache keys.
  • Each workflow runner instance runs a single version of python (looking at the previous logs, some commands were running on different versions). Is this ok? It seemed preferable.
  • Commands are mostly run via pipenv, but we don't have a lockfile. Why?
  • Pytest is configured to suppress any CryptographyDeprecationWarning, is this acceptable?
  • Moved flake8 config from tox.ini to config.cfg so it was available to CI runs, appveyor, ect./ Is this ok?

How to test the changes (if needed)

  • View CircleCI and Appveyor logs.

@bmos bmos force-pushed the patch-2 branch 9 times, most recently from 2dc98ae to 976e465 Compare February 26, 2026 19:32
@bmos bmos marked this pull request as ready for review February 26, 2026 19:57
@bmos bmos force-pushed the patch-2 branch 4 times, most recently from dee880a to 74876e1 Compare February 28, 2026 19:26
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 28, 2026

Coverage Status

coverage: 91.654% (-0.01%) from 91.667%
when pulling 0f02dc8 on bmos:patch-2
into dc07328 on pahaz:master.

@bmos bmos force-pushed the patch-2 branch 12 times, most recently from e053ef9 to bafc87c Compare March 1, 2026 15:31
bmos added 3 commits March 5, 2026 15:42
Updated CircleCI configuration to use new Python version parameters and refactored job definitions for better maintainability.
@bmos bmos changed the title Refactor CircleCI config for Python version management Refactor CI configs to test all supported versions possible Mar 5, 2026
@bmos bmos changed the title Refactor CI configs to test all supported versions possible fix ci configuration Mar 6, 2026
This was referenced Mar 6, 2026
@bmos bmos force-pushed the patch-2 branch 2 times, most recently from baa439c to 9fb70bb Compare March 8, 2026 04:01
@bmos
Copy link
Copy Markdown
Author

bmos commented Apr 7, 2026

@pahaz When you have a chance can you give this a look-over? I think I have resolved every CI issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants