Skip to content

Excavator: Remove calls to deprecated APIs #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Excavator: Remove calls to deprecated APIs #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions idea-plugin/src/main/java/com/palantir/javaformat/intellij/FormatterProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ final class FormatterProvider {
private final LoadingCache<FormatterCacheKey, Optional<FormatterService>> implementationCache =
Caffeine.newBuilder().maximumSize(1).build(FormatterProvider::createFormatter);

@SuppressWarnings("for-rollout:deprecation")
static IdeaPluginDescriptor getPluginDescriptor() {
return Preconditions.checkNotNull(
PluginManager.getPlugin(PluginId.getId(PLUGIN_ID)), "Couldn't find our own plugin: %s", PLUGIN_ID);
Expand Down Expand Up @@ -125,7 +124,6 @@ private static List<Path> getProvidedImplementationUrls(List<URI> implementation
private static List<Path> getBundledImplementationUrls() {
// Load from the jars bundled with the plugin.
IdeaPluginDescriptor ourPlugin = getPluginDescriptor();
@SuppressWarnings("for-rollout:deprecation")
Path implDir = ourPlugin.getPath().toPath().resolve("impl");
log.debug("Using palantir-java-format implementation bundled with plugin: {}", implDir);
return listDirAsUrlsUnchecked(implDir);
Expand Down Expand Up @@ -174,7 +172,6 @@ private static OptionalInt getSdkVersion(Project project) {
private static OptionalInt parseSdkJavaVersion(Sdk sdk) {
// Parses the actual version out of "SDK#getVersionString" which returns 'java version "15"'
// or 'openjdk version "15.0.2"'.
@SuppressWarnings("for-rollout:deprecation")
String version = Preconditions.checkNotNull(
JdkUtil.getJdkMainAttribute(sdk, Name.IMPLEMENTATION_VERSION), "JDK version is null");
return parseSdkJavaVersion(version);
Expand Down
1 change: 0 additions & 1 deletion palantir-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1828,7 +1828,6 @@ boolean visitSingleMemberAnnotation(AnnotationTree node) {
return true;
}

@SuppressWarnings("for-rollout:deprecation")
@Override
public Void visitCase(CaseTree node, Void unused) {
sync(node);
Expand Down