Fix test failues due to C99 warning on macos (Apple clang)#646
Closed
bjornbm wants to merge 1 commit intopallene-lang:masterfrom
Closed
Fix test failues due to C99 warning on macos (Apple clang)#646bjornbm wants to merge 1 commit intopallene-lang:masterfrom
bjornbm wants to merge 1 commit intopallene-lang:masterfrom
Conversation
Contributor
Author
|
FYI the source of the problem: https://github.com/pallene-lang/lua-internals/blob/4197fc71a7967436d117e3eb17c2aa04a5a5fd57/src/gen-lua-core-h.awk#L22 I guess the awk script could be updated to not include repeated definitions. It would be a bit ad hoc and ugly perhaps, but arguably so is the inclusion at the top? |
Contributor
Author
|
See the proposed fix at pallene-lang/lua-internals#6 instead which avoids the C99 deviation and avoids the need for this change proposed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to prevent complilation failure on macos (Apple clang). Exemple of the failure message is shown below.
I guess another option is to avoid the CallInfo redefinitiion on
luacore.hline 2386 to make in C99 compliant?