Add function to generate openapi spec.#57
Open
The-Podsiadly wants to merge 1 commit intopallets-eco:masterfrom
Open
Add function to generate openapi spec.#57The-Podsiadly wants to merge 1 commit intopallets-eco:masterfrom
The-Podsiadly wants to merge 1 commit intopallets-eco:masterfrom
Conversation
bauerji
requested changes
Aug 14, 2022
Collaborator
bauerji
left a comment
bauerji
left a comment
There was a problem hiding this comment.
Looks good, thanks! Please have a look at these comments, than I will try how it works in action
The-Podsiadly
force-pushed
the
feature/41/openapi-docs
branch
from
43c3cb9 to
dfba9ee
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
@The-Podsiadly Please, check the linter errors in the tests and modify the code accordingly. Can you please add some tests for the |
|
Any hope this might get integrated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built off of @buildpeak's forked PR #41. Added
parse_urlmethod to mimic whatwerkzeug's did. This was copied from flask-restx's PR #463.