Skip to content

Do not overwrite the logger config on app.run #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
embeddedc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not overwrite the logger config on app.run #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/quart/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,18 +912,17 @@ def run_task(
keyfile: Path to the SSL key file.

"""
config = HyperConfig()
config.access_log_format = "%(h)s %(r)s %(s)s %(b)s %(D)s"
config.accesslog = "-"
config.bind = [f"{host}:{port}"]
config.ca_certs = ca_certs
config.certfile = certfile
hconfig = HyperConfig()
hconfig.bind = [f"{host}:{port}"]
hconfig.ca_certs = ca_certs
hconfig.certfile = certfile
hconfig.keyfile = keyfile
if debug is not None:
self.debug = debug
config.errorlog = config.accesslog
config.keyfile = keyfile
hconfig.accesslog = self.logger
hconfig.errorlog = self.logger

return serve(self, config, shutdown_trigger=shutdown_trigger)
return serve(self, hconfig, shutdown_trigger=shutdown_trigger)

def test_client(
self, use_cookies: bool = True, **kwargs: Any
Expand Down