Skip to content

Fix issue with using .assign() with result from df.get() #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

Fix issue with using .assign() with result from df.get() #1463

merged 2 commits into from
Oct 31, 2025

Conversation

@Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Oct 31, 2025

Following code was failing:

df.assign(foo=lambda df: df.get("abc", None))

saying that a callable returning Series | None could not work. This PR fixes that.

@Dr-Irv Dr-Irv requested a review from cmp0xff October 31, 2025 15:18
cmp0xff
cmp0xff approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently related to #1238 and #1239. Thank you @Dr-Irv !

@cmp0xff cmp0xff merged commit 45ac3c1 into pandas-dev:main Oct 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmp0xff cmp0xff cmp0xff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dr-Irv @cmp0xff