Drop ANN ignores from certain files in arrays #1583
Merged
+75
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is a subset of the changes proposed in #1568 (which did not raise any requests), added tests for some of the types. |
cmp0xff
requested changes
Dec 23, 2025
cmp0xff
requested changes
Dec 23, 2025
cmp0xff
reviewed
Dec 23, 2025
pandas-stubs/core/arrays/integer.pyi
Outdated
|
|
||
| if sys.version_info >= (3, 11): | ||
| def __init__( | ||
| self, values: AnyArrayLike, mask: np_1darray_bool, copy: bool = False |
Contributor
There was a problem hiding this comment.
Suggested change
| self, values: AnyArrayLike, mask: np_1darray_bool, copy: bool = False | |
| self, values: AnyArrayLike, mask: np_ndarray_bool, copy: bool = False |
Wouldn't nd instead of 1d work in all versions?
Member
Author
There was a problem hiding this comment.
Arghhh I see the issue, I tried np_1darray_bool last time and not np_ndarray_bool
cmp0xff
approved these changes
Dec 23, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @loicdiridollou !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value)AGENTS.md.