Removed float addition test, reintroduced check for float type nulls

Author: eicchen

pandas/core/arrays/arrow/array.py

@@ -906,6 +906,9 @@ def _evaluate_op_method(self, other, op, arrow_funcs) -> Self:
         ):
             if op in [operator.add, roperator.radd]:
                 sep = pa.scalar("", type=pa_type)
+                if is_scalar(other) or isinstance(other, pa.Scalar):
+                    if len(other) == 0 or isna(other).any():
+                        other = other.cast(pa_type)
                 try:
                     if op is operator.add:
                         result = pc.binary_join_element_wise(self._pa_array, other, sep)

pandas/tests/arrays/floating/test_arithmetic.py

@@ -153,41 +153,8 @@ def test_error_invalid_values(data, all_arithmetic_operators):
 
     # invalid array-likes
     str_ser = pd.Series("foo", index=s.index)
-    if (
-        all_arithmetic_operators
-        in [
-            "__add__",
-            "__radd__",
-        ]
-        and pd.options.future.infer_string
-    ):
-        res = ops(str_ser)
-        if all_arithmetic_operators == "__radd__":
-            data_expected = []
-            for i in data:
-                if pd.isna(i):
-                    data_expected.append(i)
-                elif i.is_integer():
-                    data_expected.append("foo" + str(int(i)))
-                else:
-                    data_expected.append("foo" + str(i))
-
-            expected = pd.Series(data_expected, index=s.index)
-        else:
-            data_expected = []
-            for i in data:
-                if pd.isna(i):
-                    data_expected.append(i)
-                elif i.is_integer():
-                    data_expected.append(str(int(i)) + "foo")
-                else:
-                    data_expected.append(str(i) + "foo")
-
-            expected = pd.Series(data_expected, index=s.index)
-        tm.assert_series_equal(res, expected)
-    else:
-        with pytest.raises(TypeError, match=msg):
-            ops(str_ser)
+    with pytest.raises(TypeError, match=msg):
+        ops(str_ser)
 
     msg = "|".join(
         [

pandas/tests/frame/test_arithmetic.py

@@ -708,7 +708,17 @@ def test_arith_flex_zero_len_raises(self):
         with pytest.raises(TypeError, match=msg):
             df.add(ser_len0, fill_value="E")
 
-        df_len0.sub(df["A"], axis=None, fill_value=3)
+        result = df_len0.sub(df, axis=None, fill_value=3)
+        expected = DataFrame([[2, 1], [0, -1]], columns=["A", "B"])
+        tm.assert_frame_equal(result, expected, check_dtype=False)
+
+        result = df_len0.sub(df["A"], axis=0, fill_value=3)
+        expected = DataFrame([[2, 2], [0, 0]], columns=["A", "B"])
+        tm.assert_frame_equal(result, expected, check_dtype=False)
+
+        result = df_len0.sub(df["A"], axis=1, fill_value=3)
+        expected = DataFrame([], columns=["A", "B", 0, 1])
+        tm.assert_frame_equal(result, expected, check_dtype=False)
 
     def test_flex_add_scalar_fill_value(self):
         # GH#12723