PERF: Move variables outside of the for loop to improve performance #62234
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
av-runner
changed the title
jbrockmendel
reviewed
Sep 2, 2025
| for _ in range(10): | ||
| base = "\u00e5".encode() | ||
| escape_input = base * 1024 * 1024 * 2 |
There was a problem hiding this comment.
do we know why theses are defined here in the first place? the looping nature of the test makes me think it could be intentional. e.g. having id(base) change every time might matter
There was a problem hiding this comment.
I could not find anything as to why that might be needed.
There was a problem hiding this comment.
The oldest commit that I could find regarding this test was 73763af, and the reassignment inside the loop does seem intentional to stress test the decoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Description
This improves the performance in big escape decoding and encoding test. Instead of creating the escape input 10 times in a loop, the string is created outside the loop once.