TST: regression test for GH#56853 (insert/delete with MultiIndex datetime) #62238
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've opened a PR which adds a regression test for this issue: #56853. |
|
All checks have passed, I request one of the members to review the changes and kindly merge this PR. Thanks :) |
rhshadrach
requested changes
Sep 2, 2025
Comment on lines
+101
to
+104
| from pandas import ( | ||
| DataFrame, | ||
| Timestamp, | ||
| ) |
There was a problem hiding this comment.
Can you move this to the top of the file
Comment on lines
+111
to
+113
| # Verify MultiIndex and that 'B' appears in the top level | ||
| assert isinstance(df.columns, MultiIndex) | ||
| assert "B" in df.columns.get_level_values(0) |
There was a problem hiding this comment.
Can you instead check the entire state of df. Also the comment repeats the code and can be removed.
expected = ...
tm.assert_frame_equal(df, expected)There was a problem hiding this comment.
Thanks for your reply! I will surely implement these changes after school. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for a bug where inserting and then deleting
a column in a DataFrame with two-level MultiIndex columns (with a Timestamp
level) used to raise a RecursionError.
The bug is already fixed on main, but this test makes sure it won’t come back.
Test location:
pandas/tests/frame/indexing/test_insert.pyTest method:
TestDataFrameInsert.test_insert_delete_mixed_multiindex_columns