ENH: add ignore index logic for df.isin() function #62620
+95
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saakshimore
force-pushed
the
feat/isin-ignore-index
branch
from
dd28cec to
57284f0
Compare
|
pyodide unit test build fail isn't relevant to the changes I have proposed and seems to be a general issue affecting other PRs too |
saakshimore
force-pushed
the
feat/isin-ignore-index
branch
from
57284f0 to
9cce864
Compare
natmokval
added
Enhancement
Reshaping
|
@saakshimore, thanks for working on this. Could you please add a note in Regarding your tests:
|
WillAyd
requested changes
Nov 4, 2025
| raise ValueError("cannot compute isin with a duplicate axis.") | ||
| result = self.eq(values.reindex_like(self)) | ||
| if ignore_index: | ||
| result = self.isin(values.to_dict("list")) |
There was a problem hiding this comment.
Converting a DataFrame to a Python dictionary is going to be a huge performance hit, and may introduce different comparison semantics than what pandas offers naturally. Is there a way to accomplish this using the built-in indexers, much like the not ignore_index case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Added ignore_index feature for df.isin() as part of #7258. Next step would be to add the check_entire_row param.