Skip to content

Add test for combine between two series #62674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

Add test for combine between two series #62674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6987cdd
add test for combine between two series
Tsmith-77 Oct 13, 2025
eb031e1
Remove unneeded comment
Tsmith-77 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions pandas/tests/series/methods/test_combine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
from pandas import Series
from pandas import (
NA,
Series,
)
import pandas._testing as tm


class TestCombine:
def test_combine_scalar(self):
# GH#21248
# Note - combine() with another Series is tested elsewhere because
# it is used when testing operators
ser = Series([i * 10 for i in range(5)])
result = ser.combine(3, lambda x, y: x + y)
expected = Series([i * 10 + 3 for i in range(5)])
Expand All @@ -15,3 +16,11 @@ def test_combine_scalar(self):
result = ser.combine(22, lambda x, y: min(x, y))
expected = Series([min(i * 10, 22) for i in range(5)])
tm.assert_series_equal(result, expected)

def test_combine_series(self):
# GH#31899
s1 = Series([91, NA, 94], dtype="Int8")
s2 = Series([91, NA, 11], dtype="Int8")
result = s1.combine(s2, lambda x, y: x + y)
expected = Series([-74, NA, 105], dtype="Int8") # dtype should be preserved
tm.assert_series_equal(result, expected)
Loading