BUG: DataFrame.min with skipna=True raises TypeError when column contains np.nan and datetime.date #62762
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,64 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
there is already a test_reductions.py file
| numeric_only: bool = False, | ||
| **kwargs, | ||
| ): | ||
| self.convert_date_na_columns() |
There was a problem hiding this comment.
don't modify the dataframe.
| def is_date_or_null_column(self, column: Series) -> bool: | ||
| """Check if a pandas Series contains only datetime.date objects or nulls.""" | ||
| for value in column: | ||
| from datetime import date |
There was a problem hiding this comment.
imports at the top of the file
| for value in column: | ||
| from datetime import date | ||
| if not (isna(value) or isinstance(value, date)): | ||
| return False |
|
This PR is targeting the wrong branch. It should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.