Skip to content

Create .editorconfig #62736 #62900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Create .editorconfig #62736 #62900

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
52e07b5
BUG: Validate numeric_only parameter in groupby aggregations
Zrahay Oct 25, 2025
b2f18ef
BUG: Validate numeric_only parameter in groupby aggregations
Zrahay Oct 25, 2025
9655a9a
Removed the if condition and added is_bool. Removed the unecessary co…
Zrahay Oct 25, 2025
6ef5696
Added a note to the whatsnew 3.0 with respect to my issue 62778
Zrahay Oct 25, 2025
5a72c79
Added the suggested changes. Removed the redundant comments and tests…
Zrahay Oct 26, 2025
8056bb8
Change made to the comments in whatsnew 3.0
Zrahay Oct 26, 2025
63f8443
Apply pre-commit formatting fixes
Oct 26, 2025
bb9b0ab
Sort whatsnew entries alphabetically
Oct 26, 2025
8a7918f
Add .editorconfig for consistent editor settings
Zrahay Oct 28, 2025
b89a087
Merge remote-tracking branch 'origin/main' into feature/editorconfig
Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@

root = true

[*]
charset = UTF-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This instruction is a little bit invasive to be applied for all files

spelling_language = en-us

[*.py]
max_line_length = 88
indent_style = space
indent_size = 4

[*.pyx]
max_line_length = 88
indent_style = space
indent_size = 4
Comment on lines +11 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge these 2 instructions



[*.c]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include .h

max_line_length = 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to don't add max_line_length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should I follow this only for this .c or every other file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no intent in adding this file to the repository.

But FYI, it depends mainly on linting settings. For Python and Pyrex this setting is enforced, so it would be beneficial. I don't recall how it's defined for C, but a textwidth of 80 seems small.

indent_style = space
indent_size = 2

[meson.build]
max_line_length = 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

indent_style = space
indent_size = 4

[*.{yml,yaml}]
indent_style = space
indent_size = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files in the codebase has an indent size of 2, others has of 4. Keep it in 2 for now.


[*.json]
indent_style = space
indent_size = 4


[*.sh]
indent_style = space
indent_size = 4

[*.rst]
indent_style = space
indent_size = 4
Loading