Fix seqwish dep: point to rust-2 (includes label prop revert)#159
Merged
Conversation
The transclosure-optimize branch had a race condition in label propagation that crashed on USP14. The rust-2 branch has the fix (reverted to DisjointSetsAsm) while keeping all other optimizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seqwish dependency was pointing to
transclosure-optimizebranch which has a race condition causing crashes on larger inputs (USP14 region). Update torust-2which has the fix (PR pangenome/seqwish#137 reverted label propagation to DisjointSetsAsm).Smoke test: MHC C4 region produces correct output (2727 nodes, 52047bp).