Feature/add spatial disaggregation recipe

[dgergel]

This PR adds the following:

1. a full recipe for implementing the Thrasher et al. 2012 method for spatial disaggregation that is part of the Bias Correction and Spatial Disaggregation (BCSD) daily downscaling method
2. structure for a new class of spatial models
3. a fit/predict method for spatial disaggregation using the SpatialDisaggregator class in spatial models

[jhamman]

@dgergel - I just merged some changes in that should fix the CI for you. Go ahead and pull those in and then I'll take a look here.

[dgergel]

@jhamman sorry for the delay in fixing the pre-commit problems. This is finally ready for a review.

[jhamman]

This looks cool. Just a few comments to tidy things a bit but let's merge this soon. I suspect some iteration around the spatial models api will be needed but its good to start somewhere.

Oh! And tests, can you pull a basic set of unit tests together for the SpatialDisaggregator?

[jhamman]

Let's write this as:

Suggested change

	if var == 'temperature':
	pass
	elif var == 'precipitation':
	pass
	else:
	if var not in ['temperature', 'precipitation'] :

[dgergel]

Updated

[jhamman]

maybe something like this:

Suggested change

	if not np.array_equal(ds_bc[lat_name], climo_coarse[lat_name]):
	raise ValueError('climo latitude dimension does not match model res')
	if not np.array_equal(ds_bc[lon_name], climo_coarse[lon_name]):
	raise ValueError('climo longitude dimension does not match model res')
	if not ds_bc[lat_name].equals(climo_coarse[lat_name]):
	raise ValueError('climo latitude coordinate does not match model res')
	if not ds_bc[lon_name].equals(climo_coarse[lon_name]):
	raise ValueError('climo longitude coordinate does not match model res')

[jhamman]

minor nit but these are over-indented (same for all docstrings here)

[dgergel]

I think this is fixed now.

[codecov]

Codecov Report

Merging #57 (098d8ea) into main (8a0c27e) will not change coverage.
The diff coverage is n/a.

❗ Current head 098d8ea differs from pull request most recent head 458f292. Consider uploading reports for the commit 458f292 to get more accurate results

@@    Coverage Diff     @@
##   main   #57   +/-   ##
==========================
==========================

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0c27e...458f292. Read the comment docs.

[dgergel]

@jhamman so sorry for taking so long to get back to this. I've made the changes you suggested and added unit tests, so this is ready for another review.