chore(phpstan): fix types on ingest activity job#20
Merged
nunomaduro merged 2 commits intopanstorm-project:mainfrom Jan 24, 2025
mhdcodes:main
Merged
chore(phpstan): fix types on ingest activity job#20nunomaduro merged 2 commits intopanstorm-project:mainfrom mhdcodes:main
nunomaduro merged 2 commits intopanstorm-project:mainfrom
mhdcodes:main
Conversation
Collaborator
|
@mhdcodes can you run pint real quick and fix this CI? |
Contributor
Author
|
done. @nunomaduro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
I’ve fixed the type issues in the ingest activity job. The fixes might be a bit ugly in terms of code style, but they make PHPStan happy.