Fixing composer path for scaffolding#39
Open
stevector-streaming wants to merge 1 commit intopantheon-systems:11.xfrom
Open
Fixing composer path for scaffolding#39stevector-streaming wants to merge 1 commit intopantheon-systems:11.xfrom
stevector-streaming wants to merge 1 commit intopantheon-systems:11.xfrom
Conversation
Contributor
|
@greg-1-anderson can you review/merge this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the bug described in #38 although it seems oddly cumbersome to figure out the
DRUPAL_ROOTand then go up a directory. I would expect there's a more straightforward way to determine the root composer.json.I tested this change in a personal D11 project by:
Registering the fork at the root
composer.jsonI updated the requirement to use the branch
And then I ran the command successfully