feat: add API versioning, mobile responsive layout, and component tests#2
Merged
tmushayahama merged 4 commits intomainfrom Feb 20, 2026
Merged
feat: add API versioning, mobile responsive layout, and component tests#2tmushayahama merged 4 commits intomainfrom
tmushayahama merged 4 commits intomainfrom
Conversation
- Restructure environment.ts to match site-react constants pattern with BASE_CONFIG + VERSION_CONFIGS (pango-1/pango-2) - Add apiVersion prop with auto-detection from ?apiVersion= query param - Add align prop to pango-dropdown for right-aligned positioning
Add unit tests (spec) and end-to-end tests for both components, covering rendering, props, events, and alignment. Configure Jest image mocking in stencil.config.ts to handle PNG imports in tests.
- Remove publish.yml (superseded by semantic-release) - Update ci.yml to PR-only trigger - Update semantic-release.yml with permissions and v24 - Add commitlint config and CI workflow - Fix package.json repository URL to pantherdb/pango-toolbar - Clean up CHANGELOG.md for semantic-release ownership - Expand README with contributing guide and release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#1
Changes
API Versioning (
pango-toolbar)apiVersionprop ('pango-1' | 'pango-2', defaultpango-2) for switching between v1/v2 configurations?apiVersion=from URL whenapi-versionattribute is not setgetConfig()Environment Constants (
environment.ts)ENVIRONMENTobject toBASE_CONFIG+VERSION_CONFIGSkeyed by version/v1/segment; V2 ontology URL updatedAPP_VERSION,GO_RELEASE,PANTHER_VERSIONMobile Responsive Layout
Dropdown Enhancements (
pango-dropdown)alignprop ('left' | 'right') for dropdown positioning--pango-dropdown-trigger-paddingCSS variableTests
pango-toolbar(default rendering, custom props, download links, V1/V2 URLs, partner logos)pango-dropdown(rendering, toggle, events, alignment)stencil.config.tsfor Jest PNG handlingCI/CD & Release Workflow
publish.ymlworkflowci.ymlto PR-only trigger (semantic-release handles push-to-main)semantic-release.ymlwith explicit permissions and v24package.jsonrepository URL topantherdb/pango-toolbarDocumentation
Test plan
v0.1.0created with auto-generated notescc @mugitty @dustine32