Fixed null select keys to correctly trigger trackers using only skill keys#11
Open
jwaples wants to merge 1 commit intopanthernet:masterfrom
Open
Fixed null select keys to correctly trigger trackers using only skill keys#11jwaples wants to merge 1 commit intopanthernet:masterfrom
jwaples wants to merge 1 commit intopanthernet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the following option in D2R, you do not need to provide a 'select' key as skills are cast immediately when using the skill input, so instead trackers should immediately be toggled when the skill key is pressed.
This behaviour wasn't happening, when debugging I found SkillDataItem.cs needed a tiny update to fix it - however then found a null reference occurring afterwards which I also fixed. Thx for your efforts on this project 🚀