-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor create battle #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pantoja
wants to merge
19
commits into
staging
Choose a base branch
from
refactor-create-battle
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorfsf
reviewed
May 26, 2020
backend/api/battles/views.py
Outdated
Comment on lines
26
to
27
| return queryset.annotate(num_teams=Count("teams")).filter(num_teams=2) | ||
| return queryset.annotate(num_teams=Count("teams")).filter(num_teams=1) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotate could be part of the queryset above, before the if. There's less repetition this way.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Refactored Create Battle page using React.
Refactored the endpoints involved (battle creation, pokemon listing a user listing)
Used react-bootstrap-typeahead to render input field with typeahead
Used react-sortable-hoc to allow user to sort pokemon by using drag and drop
Trello Card
As a Programmer I refactor the battle creation page to React
Screenshots (if appropriate):
Steps to reproduce (if appropriate):
Link: https://staging-pantoja-pokebattle.herokuapp.com/
Credentials:
username: admin@admin.compassword: senhaadminor you can register