Skip to content

thread name for the workunit streamer#23277

Merged
cburroughs merged 2 commits intopantsbuild:mainfrom
cburroughs:csb/workstream-thread-name
Apr 28, 2026
Merged

thread name for the workunit streamer#23277
cburroughs merged 2 commits intopantsbuild:mainfrom
cburroughs:csb/workstream-thread-name

Conversation

@cburroughs
Copy link
Copy Markdown
Contributor

This is so it shows up more clearly in stacktraces or perf.

Test Plan

In it this repo:

PANTS_WORKUNIT_LOGGER_ENABLED=true pants check ::

While running:

gstack $(cat .pants.d/pids/35b2225442f6/pantsd/pid ) > /tmp/stack
$ grep worku /tmp/stack
Thread 2 (Thread 0x7ee0728296c0 (LWP 426293) "workunit-stream"):

@cburroughs cburroughs self-assigned this Apr 21, 2026
@cburroughs cburroughs added the release-notes:not-required [CI] PR doesn't require mention in release notes label Apr 21, 2026
@cburroughs cburroughs changed the title thread name to the therad for the workunit handler thread name for the workunit streamer Apr 21, 2026
@cburroughs cburroughs marked this pull request as ready for review April 21, 2026 02:33
Copy link
Copy Markdown
Member

@sureshjoshi sureshjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a release note, as I think people in chat have mentioned using this - and so if anyone else put automation around this, they should know they might need to change it

This is so it shows up more clearly in stacktraces or `perf`.
@cburroughs cburroughs force-pushed the csb/workstream-thread-name branch from bcc0857 to 7bbe025 Compare April 27, 2026 16:43
@cburroughs cburroughs enabled auto-merge (squash) April 27, 2026 16:43
@cburroughs cburroughs merged commit 6aecac3 into pantsbuild:main Apr 28, 2026
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants