信件與性別問題 #2
+19
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,11 @@ function About() { | |
| return false | ||
| } | ||
|
|
||
| console.log('mail: ', payload.email); | ||
| if(payload.email.length < 20) { | ||
| return false | ||
| } | ||
|
|
||
| if(payload.name === '') { | ||
| return false | ||
| } | ||
|
|
@@ -32,9 +37,16 @@ function About() { | |
| const {startTime, endTime, sex, name, phone} = payload | ||
| const startTimeString = format(startTime, 'yyyy/MM/dd HH:mm') | ||
| const endTimeString = format(endTime, 'yyyy/MM/dd HH:mm') | ||
|
|
||
| if(sex < 1 || sex > 2) { | ||
| return { success: false, result: '性別格式錯誤' } | ||
| } | ||
| const sexString = sex === 1 ? '男' : '女' | ||
|
|
||
| return { | ||
| success: true, | ||
| result: `活動時間：${startTimeString} ~ ${endTimeString}，性別：${sexString}，姓名：${name}，電話：${phone}` | ||
| } | ||
| } | ||
|
|
||
| function handleHallClick() { | ||
|
|
@@ -43,7 +55,12 @@ function About() { | |
| } | ||
|
|
||
| const activityString = getActivityString(mockAPIData) | ||
|
|
||
| if(!activityString.success) { | ||
| alert(activityString.result) | ||
| } else { | ||
|
Comment on lines
+59
to
+61
There was a problem hiding this comment. Consider using a more user-friendly way to display the error message instead of // alert(activityString.result)
// TODO: Implement a better way to display the error message
// e.g., using a modal or an inline error message
Owner
Author
There was a problem hiding this comment. Due to the tight schedule, using alerts was allowed after discussion with the team. There was a problem hiding this comment. Understood. Given the team's decision to use alerts due to the schedule, I won't push further on that point. However, for future reference and when time allows, consider exploring alternative methods for displaying error messages to enhance the user experience. Thanks for the update, @paperhsiaooo! |
||
| // get hall data with "activityString" from api ... | ||
| } | ||
| } | ||
|
|
||
| const handleEmailClick = () => { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The email length validation might be too restrictive. Consider making this configurable or removing it altogether. What is the rationale behind the length check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I don’t want users to enter random emails, I want to limit the length of the email field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying your reasoning. While I understand the intent to prevent random email entries, a simple length check might not be the most effective way to validate email format. Users could still enter long strings of gibberish that pass the length check but are not valid emails.
Consider using a more robust email validation method, such as a regular expression, or a third-party library specifically designed for email validation. This would provide a more accurate way to ensure that the entered email is in a valid format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gemini-code-assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome. I'm glad I could help. Let me know if you have any further questions.