Skip to content

getZoom return 0 #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unpete wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

getZoom return 0 #2048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/view/View.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ var View = Base.extend(Emitter, /** @lends View# */{
getZoom: function() {
var scaling = this._decompose().scaling;
// Use average since it can be non-uniform.
return (scaling.x + scaling.y) / 2;
return (Math.abs(scaling.x) + Math.abs(scaling.y)) / 2; // for mirrored in x (x=-1, y=1), result was 0 and crash project dividing by 0
},

setZoom: function(zoom) {
Expand Down