Friendly (traceless) error messages#77
Open
DannyBen wants to merge 4 commits intopapertrail:masterfrom
Open
Conversation
Contributor
|
Good addition. I'd be in favor of moving the exception handling behavior out into |
Contributor
Author
|
Makes sense. Will update the PR later today. |
Contributor
Author
|
@lmarburger - better? |
Contributor
Author
|
Note that in the other bin+lib pairs, there is also some inconsistency. For example:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes to improve error messages by showing only the message, and not the trace.
It rescues two exceptions:
ArgumentError- raised in some cases across the code, for example - when providing an invalid argument to--min-timeOptionParser::InvalidOption- which is raised when parsing unexpected optionAfter merging, you get these: