Open
Conversation
lmarburger
reviewed
Jul 11, 2017
Contributor
lmarburger
left a comment
lmarburger
left a comment
There was a problem hiding this comment.
If a ruby file uses a library, I'm all for having it explicitly require it. Otherwise, that file can only run by using an opaque loading mechanism where the libs required globally are known.
| require 'rubygems' | ||
| require 'rake' | ||
| require 'date' | ||
| require File.expand_path('../lib/papertrail/version', __FILE__) |
Contributor
There was a problem hiding this comment.
lib/ should be in the path when this is run so "papertrail/version" should be all that's necessary to require.
Contributor
Author
There was a problem hiding this comment.
Nope. Doesn't work 😢
Contributor
Author
|
@lmarburger I waffled on what made more sense with requiring papertrail, and your comment makes me think maybe I chose the wrong course. Would it be better to put the |
sethherr
force-pushed
the
revise_requires
branch
from
91e4f32 to
ce5ef0f
Compare
sethherr
force-pushed
the
revise_requires
branch
from
ce5ef0f to
28a3476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.