Skip to content

Fix Alpine bug with missing "theme" property, and lazy-load CSS/JS assets #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Alpine bug with missing "theme" property, and lazy-load CSS/JS assets #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c08df9
Only load CSS/JS assets on request
jackwh Mar 2, 2024
8fa82a4
Set theme on Alpine component
jackwh Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resources/views/syntax-entry.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class="filament-syntax-entry"
>
<div
x-data="{
theme: localStorage.getItem('theme') ?? @js(filament()->getDefaultThemeMode()->value),
init() {
this.updateTheme();
const observer = new MutationObserver(() => this.updateTheme());
Expand Down
4 changes: 2 additions & 2 deletions src/FilamentSyntaxEntryServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ protected function getAssetPackageName(): ?string
protected function getAssets(): array
{
return [
Css::make('filament-syntax-entry-styles', __DIR__ . '/../resources/dist/filament-syntax-entry.css'),
Js::make('filament-syntax-entry-scripts', __DIR__ . '/../resources/dist/filament-syntax-entry.js'),
Css::make('filament-syntax-entry-styles', __DIR__ . '/../resources/dist/filament-syntax-entry.css')->loadedOnRequest(),
Js::make('filament-syntax-entry-scripts', __DIR__ . '/../resources/dist/filament-syntax-entry.js')->loadedOnRequest(),
];
}

Expand Down