Add LibertyCell::leakagePower overload using std::optional#218
Open
maliberty wants to merge 1 commit intoparallaxsw:masterfrom
Open
Add LibertyCell::leakagePower overload using std::optional#218maliberty wants to merge 1 commit intoparallaxsw:masterfrom
maliberty wants to merge 1 commit intoparallaxsw:masterfrom
Conversation
More modern C++ style Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
hzeller
reviewed
Apr 7, 2025
| LibertyCell::leakagePower() const | ||
| { | ||
| std::optional<float> leakage; | ||
| if (leakage_power_exists_) { |
Contributor
There was a problem hiding this comment.
You don't necessarily need the leakage value to assign stuff to and simplify that a bit by directly returning the value:
{
if (leakage_power_exists_) {
return leakgage_power_;
}
return std::nullopt;
}
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More modern C++ style