Support Input/output internal power#344
Open
nataliakokoromyti wants to merge 3 commits intoparallaxsw:masterfrom
Open
Support Input/output internal power#344nataliakokoromyti wants to merge 3 commits intoparallaxsw:masterfrom
nataliakokoromyti wants to merge 3 commits intoparallaxsw:masterfrom
Conversation
jjcherry56
reviewed
Dec 12, 2025
| PowerResult(); | ||
| void clear(); | ||
| float internal() const { return internal_; } | ||
| float inputinternal() const { return inputinternal_; } |
Collaborator
There was a problem hiding this comment.
the function and variable names do not follow the naming conventions.
see doc/CodiingGuidelines.txt
jjcherry56
reviewed
Dec 12, 2025
| map<const char*, float, StringLessIf> pg_duty_sum; | ||
| int numArcs = 0; | ||
| for (InternalPower *pwr : corner_cell->internalPowers(to_corner_port)) { | ||
| numArcs += 1; |
Collaborator
There was a problem hiding this comment.
the variable does not follow the coding guidelines.
look around. you will never see "num" anything.
It should be arc_count
jjcherry56
reviewed
Dec 12, 2025
| } | ||
| } | ||
| // The number of pins that consume internal power in total | ||
| float numInternalPowerPins = numArcs / (float) pg_duty_sum.size(); |
jjcherry56
reviewed
Dec 12, 2025
| } | ||
| } | ||
|
|
||
| define_cmd_args "report_internal_power_components" { [> filename] [>> filename] } |
Collaborator
There was a problem hiding this comment.
why does this require a reporting function? none of the other power types have unique reporting functions.
Collaborator
|
What is the point of distinguishing input and output internal power? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for querying both input and output internal power in gate power analysis.
Features:
get_input_internal_power()andget_output_internal_power()commandsBased on Silimate/OpenSTA implementation with upstream integration.