Make defineProperty take handler by const& and clean up std::moves#427
Merged
jjcherry56 merged 1 commit intoparallaxsw:masterfrom Apr 21, 2026
Merged
Conversation
Signed-off-by: Drew Lewis <cannada@google.com>
jjcherry56
reviewed
Apr 21, 2026
| PropertyHandler handler) | ||
| { | ||
| registry_[std::string(property)] = std::move(std::move(std::move(std::move(std::move(std::move(std::move(std::move(std::move(std::move(handler)))))))))); | ||
| registry_[std::string(property)] = std::move(handler); |
Collaborator
There was a problem hiding this comment.
WTF, claude stuttering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you leave them as non-const & then you can't pass rvalue lambdas in via this interface anymore.