Add comprehensive linting setup and enhanced GitHub workflow #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .luacheckrc with Neovim-specific linting rules - Add Makefile with lint, test, and utility targets - Configure appropriate warning ignores for plugin development - Set 100 character line limit for consistent formatting
- Fix logic issues by replacing inefficient loops with next() function calls - Break long lines to comply with 100 character limit - Remove trailing whitespace throughout codebase - Fix read-only field warnings in tests using proper metatable approach - Add test-setup.sh script for isolated testing environment - Achieve zero linting warnings across all Lua files
- Rename workflow from 'Tests' to 'CI' for broader scope - Add parallel lint job with luacheck installation - Update test job to use make commands for consistency - Enhance README contributing section with development tools documentation - Document all Makefile targets and CI integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive code quality improvements and CI enhancements:
Key Changes
Code Quality & Linting
.luacheckrcwith comprehensive configuration for Neovim/Lua standardsCI/CD Improvements
Developer Experience
test,lint,lint-fix,clean,check-depsTest Plan
This PR establishes a solid foundation for code quality and makes the project more maintainable for future contributions.