fix: handle pipe separator in link following with gf #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract only the filename part from wikilinks when following with gf, ignoring display text after pipe separator (e.g., [[file|display]] -> file).
Add test cases for: - Basic wikilink following - Pipe-separated display text links (main fix) - Links with paths and pipe separators - Multiple pipe characters in display text - Fuzzy search fallback functionality - Error handling for missing files - Graceful handling when cursor not on wikilink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gfcommand to properly follow wikilinks with pipe-separated display text[[some/long-filename|Short title]]Test plan
gfon links without pipe separator (existing functionality)gfon links with pipe separator like[[file|display text]]