fix: add symlink support to find commands #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The find commands in tag search and link following were failing when vault_path was a symbolic link because find doesn't follow symlinks by default. This caused "No tags found in frontmatter" errors and link following failures when using symlinked vaults. Added -L flag to find commands to follow symbolic links in: - search_tags() function in notes.lua - follow_link() fuzzy search fallback in links.lua This allows the plugin to work correctly with symlinked vault directories (e.g., ~/personal/docs/notes -> ~/personal/repos/notes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-Lflag to find commands to follow symlinksProblem
The
findcommand doesn't follow symbolic links by default. When a user'svault_pathpoints to a symlink (e.g.,~/personal/docs/notes→~/personal/repos/notes), the find commands would return 0 files, causing:Solution
Added the
-Lflag to find commands in:search_tags()inlua/markdown-notes/notes.lua(line 164)follow_link()fuzzy search fallback inlua/markdown-notes/links.lua(line 73)Testing
Tested with symlinked vault:
Changes
lua/markdown-notes/notes.lua: Added-Lto find command in search_tagslua/markdown-notes/links.lua: Added-Lto find command in follow_link fallback