Handle workspace dependencies#35
Draft
joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
Draft
Handle workspace dependencies#35joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
Conversation
> Other than optional and features, inherited dependencies cannot use any other dependency key (such as version or default-features). https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
bkchr
requested changes
Jan 10, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
We should patch them in the workspace dependencies table and skip these dependencies down in the tree.
Author
Ok. Then this change needs a rework. Moving to Draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Per https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
dienerdoesn't take into accountworkspacedependencies, thus it would fail to effectively patch them and leave the code in a broken state.Solution
Remove
.workspacefrom entries before patching them.Later on a flag
--workspace-dependencies=[patch|skip]can be added to configure this behavior.