Skip to content

kad: Ensure addresses are propagated only in automatic #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −6
Open

kad: Ensure addresses are propagated only in automatic #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e47639
kad: Ensure addresses are propagated only in automatic
lexnv Nov 21, 2025
db275c0
kad: Expose addresses for the routing table events
lexnv Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/protocol/libp2p/kademlia/handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ pub enum KademliaEvent {
/// in order to add the peers to routing table.
RoutingTableUpdate {
/// Discovered peers.
peers: Vec<PeerId>,
peers: Vec<(PeerId, Vec<Multiaddr>)>,
},

/// `GET_VALUE` query succeeded.
Expand Down
14 changes: 9 additions & 5 deletions src/protocol/libp2p/kademlia/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,15 +435,19 @@ impl Kademlia {
let _ = self
.event_tx
.send(KademliaEvent::RoutingTableUpdate {
peers: peers.iter().map(|peer| peer.peer).collect::<Vec<PeerId>>(),
peers: peers
.iter()
.map(|peer| (peer.peer, peer.addresses()))
.collect::<Vec<(PeerId, Vec<Multiaddr>)>>(),
})
.await;

for info in peers {
let addresses = info.addresses();
self.service.add_known_address(&info.peer, addresses.clone().into_iter());
if std::matches!(self.update_mode, RoutingTableUpdateMode::Automatic) {
for info in peers {
let addresses = info.addresses();

self.service.add_known_address(&info.peer, addresses.clone().into_iter());

if std::matches!(self.update_mode, RoutingTableUpdateMode::Automatic) {
self.routing_table.add_known_peer(
info.peer,
addresses,
Expand Down
Loading