webrtc: Avoid future being dropped when channel is full #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Draft for two reasons:
@lexnv should I wait for #465 to get merged and then merge |
haikoschol
commented
Nov 25, 2025
| } | ||
|
|
||
| // TODO: try to coalesce multiple calls to `poll_write()` into single `Event::Message` | ||
| loop { |
Author
There was a problem hiding this comment.
This loop is part of the code generated by Gemini, but I think it will only ever be executed once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #477. Specifically the issue described in this comment.