Conversation
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
I've noticed that README is outdated, could you fix the name and the link to docs as well?
| /// Macro for calling `c-style functions` and wrapping the return status in a `Result` | ||
| /// If the function return `-1` it will return `Err<$err:expr>` otherwise `Ok(int)` | ||
| // FIXME: this is not platform independent: `https://github.com/paritytech/parity-daemonize/issues/14` | ||
| macro_rules! map_err { |
There was a problem hiding this comment.
Why do we expose this macro in the first place, can we move to unix submodule/or add #[doc(hidden)]?
There was a problem hiding this comment.
I don't know and I think we shouldn't export it because it is only used internally but I would prefer keep it out of this PR.
I can mark it as #[doc(hidden)] ok?
Also I think we could re-write the macro to get full failure case, such as Rust does it: https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/mod.rs#L129-#L135
There was a problem hiding this comment.
I can mark it as
#[doc(hidden)]ok?
yep
Also I think we could re-write the macro to get full failure case, such as Rust does it: https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/mod.rs#L129-#L135
yeah, also it doesn't need to be a macro anymore, which would eliminate the need for #[doc(hidden)]
| /// Macro for calling `c-style functions` and wrapping the return status in a `Result` | ||
| /// If the function return `-1` it will return `Err<$err:expr>` otherwise `Ok(int)` | ||
| // FIXME: this is not platform independent: `https://github.com/paritytech/parity-daemonize/issues/14` | ||
| macro_rules! map_err { |
There was a problem hiding this comment.
I can mark it as
#[doc(hidden)]ok?
yep
Also I think we could re-write the macro to get full failure case, such as Rust does it: https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/mod.rs#L129-#L135
yeah, also it doesn't need to be a macro anymore, which would eliminate the need for #[doc(hidden)]
2 participants
No description provided.