Implement compact trie proofs#1166
Draft
tomaka wants to merge 6 commits intoparitytech:mainfrom
Draft
Conversation
Contributor
Author
|
Oops, I must also verify that hashes match, otherwise it's completely unsecure. |
Contributor
Author
|
We can still find inline nodes and hashes in the proof. Hashes can only be found for nodes that aren't interesting for what we want to prove. |
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Contributor
twiggy diff reportDifference in .wasm size before and after this pull request. |
mergify Bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
Necessary in order to finish #1166 Right now we can decode items from Merkle proofs. This PR implements encoding back these items. While implementing encoding, I've discovered several cases where the decoding was too lenient and was accepting as valid things that shouldn't really be valid. I've fixed this as part of this PR. See the changes in `src/util.rs` and at the bottom of `src/trie/proof_node_codec.rs`. When I say "shouldn't really be valid" I mean that there were multiple different sequences of bytes that could lead to the same decoded struct. Since we're hashing things a lot here and there, it is important that there is a bijection of decoded <-> encoded. The Substrate implementation does the same. cc paritytech/substrate#12417
dmitry-markin
pushed a commit
that referenced
this pull request
Mar 16, 2026
* Add support for `state_queryStorageAt` * Just add a TODO instead * Rustfmt
dmitry-markin
force-pushed
the
main
branch
2 times, most recently
from
dffa75f to
f471baa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #910
PR is ready, but two questions remain to be solved before merging: