statement-store: Add browser sanity check zombienet test#3244
Merged
AndreiEres merged 8 commits intomainfrom May 7, 2026
Merged
statement-store: Add browser sanity check zombienet test#3244AndreiEres merged 8 commits intomainfrom
AndreiEres merged 8 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
10 tasks
lrubasze
approved these changes
May 7, 2026
alvicsam
approved these changes
May 7, 2026
P1sar
reviewed
May 7, 2026
| const { send, waitForResponse, client } = window.__t; | ||
|
|
||
| let pingResult = null; | ||
| for (let attempt = 0; attempt < 10; attempt++) { |
There was a problem hiding this comment.
Why do we need to repeat submit/read 10 times? Should not is pass on first try?
Contributor
Author
There was a problem hiding this comment.
You're right; it's too defensive.
P1sar
reviewed
May 7, 2026
| <head><meta charset="utf-8"><title>smoldot browser tests</title></head> | ||
| <body> | ||
| <script type="module"> | ||
| import * as smoldot from '/smoldot/dist/mjs/index-browser.js'; |
There was a problem hiding this comment.
very minor, but polkadot host uses Vite as a bundler maybe it make sense to also use it to build smoldot for this test. Bundlers can introduce their own problems
Contributor
Author
There was a problem hiding this comment.
very don't want to add Vite here. I tried to keep the test very simple.
…owser-check # Conflicts: # .github/workflows/zombienet.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index-browser.js) inside headless Chromium against a real polkadot-sdk full node, exercising the statement-store ping-pong path that Node-based tests cannot reach (WebSocket-only transport, streaming wasmfetch, WebCrypto, the published browser entry point).READY, then the page submits stmt_A (ping) and waits for stmt_B to arrive on its subscription (pong)..github/workflows/zombienet.ymlaszombienet-smoldot-0004-statement_store_browser, with caches fore2e-tests/browser/node_modulesand~/.cache/ms-playwright, and a conditionalnpx playwright install --with-deps chromiumstep.Test plan
cargo check --testsclean forsmoldot-e2e-testsnode --checkfore2e-tests/browser/run.mjsandhelpers.jscargo test -p smoldot-e2e-tests --test statement_store_browser -- --nocapture— fivePASS:lines (bundle loaded, subscribe to topic_B, READY, ping, pong); test result: okzombienet-smoldot-0004-statement_store_browserjob passes