network-service: remove peer_id from advertised address#3245
Merged
michalkucharczyk merged 4 commits intomainfrom May 7, 2026
Merged
network-service: remove peer_id from advertised address#3245michalkucharczyk merged 4 commits intomainfrom
michalkucharczyk merged 4 commits intomainfrom
Conversation
skunert
approved these changes
May 7, 2026
Contributor
Author
|
cc: @dmitry-markin @lexnv |
Merged
lrubasze
added a commit
that referenced
this pull request
May 7, 2026
This is to: - publish `smoldot-v3.1.2` npm. - publish crates `smoldot-light v1.1.2`, `smoldot v1.1.1` ## Changes ### Added - Log when the statement protocol substream opens, to make peer connectivity easier to diagnose. ([#3154](#3154)) ### Fixed - Strip the trailing `/p2p/<peer_id>` from discovered addresses so peers advertised in this form are no longer rejected as unsupported, restoring peer discovery beyond the configured bootnodes. ([#3245](#3245)) - Stop continuously re-trying statement-store submissions after a peer rejects them. ([#3230](#3230)) - Avoid panicking on shutdown when background tasks observe the client being torn down. ([#3243](#3243))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During tests I noticed that smoldot only connects to bootnodes in local zombie network. No other peers were discovered.
The error was:
This PR is fixing this, by poping
p2p/{peer_id}from advertised addresses.It follows the same policy as for bootnodes addresses (and also what is done in polkadot-sdk).