Zero the memory of the Wasm VM#947
Open
tomaka wants to merge 4 commits intoparitytech:mainfrom
Open
Conversation
Contributor
Author
|
Apparently Substrate restores what's below |
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
melekes
reviewed
Jan 18, 2022
melekes
approved these changes
Feb 24, 2022
Contributor
Author
|
For context I haven't merged this, because the last time I tried these changes considerably slow down the blocks verification speed of the full node (something like 50 times slower if I remember correctly), which means that I'm probably missing something that Substrate does or doesn't do. |
dmitry-markin
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ction (#947) * Refactor `WithBuffers` to be more in line with the `ReadWrite` abstraction * Fix logs showing wrong bytes count * Docfix
dmitry-markin
force-pushed
the
main
branch
2 times, most recently
from
dffa75f to
f471baa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #946
Unfortunately the full node syncing speed is now abysmal. Need to figure out what happens.